fix(nntp): materialize ARTICLE/HEAD/BODY multiline data to prevent em…#23
Open
ros32 wants to merge 1 commit intokeimpema:masterfrom
Open
fix(nntp): materialize ARTICLE/HEAD/BODY multiline data to prevent em…#23ros32 wants to merge 1 commit intokeimpema:masterfrom
ros32 wants to merge 1 commit intokeimpema:masterfrom
Conversation
…pty bodies The NNTP parser returned deferred `IEnumerable<string>` body lines backed by an enumerator created inside a `using` block. In some usage patterns (e.g., deferred enumeration, interleaved NNTP commands, keepalive/parallel workers) the enumerator would be disposed before consumers enumerated it, yielding empty bodies. Change: - In `lib/Usenet/Usenet/Nntp/Parsers/ArticleResponseParser.cs` (Parse): - Copy `dataBlock` to a list (`var lines = dataBlock?.ToList();`) - Enumerate headers from this list - Materialize body with `EnumerateBodyLines(enumerator).ToList()` - Return `NntpArticle` with fully materialized `Body` Why now: - Recent calling patterns defer enumeration and/or issue additional NNTP commands between parse and consumption, exposing the latent bug. Notes: - RFC 3977 compliance preserved; dot-stuffing and terminator remain handled by `NntpStreamReader`. - No public API changes; minor memory overhead per article body in exchange for correctness.
Contributor
|
@ros32, I recommend moving this PR into the fork at https://github.com/Spottarr/Usenet. It is being maintained more actively, and the PR will probably be merged much more quickly than if you leave it on this original fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pty bodies
The NNTP parser returned deferred
IEnumerable<string>body lines backed by an enumerator created inside ausingblock. In some usage patterns (e.g., deferred enumeration, interleaved NNTP commands, keepalive/parallel workers) the enumerator would be disposed before consumers enumerated it, yielding empty bodies.Change:
lib/Usenet/Usenet/Nntp/Parsers/ArticleResponseParser.cs(Parse):dataBlockto a list (var lines = dataBlock?.ToList();)EnumerateBodyLines(enumerator).ToList()NntpArticlewith fully materializedBodyWhy now:
Notes:
NntpStreamReader.